MuntashirAkon/AppManager

"Redo existing backups" doesn't respect per-app settings

Open

#991 opened on Feb 8, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (3,673 stars) (236 forks)batch import
BugFeature: 1-click opsFeature: BackupGood First IssuePriority: 3Severity: 2

Description

Please check before submitting an issue

  • I know what my device, OS and App Manager versions are
  • I know how to take logs
  • I know how to reproduce the issue which may not be specific to my device

Describe the bug

I backup some apps with default settings:

  • APK files
  • Internal data
  • External data
  • OBB and Media
  • Cache
  • Extras
  • Rules
  • Backup multiple

but I also backup some apps with APK only.

When going to top right menu > 1-Click Ops > Back up > Redo existing backups > selecting desired apps > Back up, we're asked to choose what to back up. It defaults to the above list.

As a result, all the apps selected are backed up with these settings, which isn't what "redo existing backups" should be doing in my opinion. Applications already backed up with APK only should be backed up again with APK only.

To Reproduce

  1. Backup an app with default settings:
  • APK files
  • Internal data
  • External data
  • OBB and Media
  • Cache
  • Extras
  • Rules
  • Backup multiple
  1. Backup another one with APK only:
  • APK files
  1. Go to top right menu
  2. 1-Click Ops
  3. Back up
  4. Redo existing backups
  5. Select both apps previously backed up
  6. Back up
  7. AppManager then asks what to backup
  8. Choose default settings
  9. The app which was backed up with APK only is now backed up with APK+data (settings chosen before)

Expected behavior

"Redo existing backups" should, well... redo backups.

Ideally, the screen where we're asked to choose what to backup wouldn't exist (AppManager should remember the settings for each app during the initial backup).

Screenshots

No response

Logs

No response

Device info

  • Device: OnePlus 7 Pro
  • OS Version: 13
  • App Manager Version: 3.0.4 (416)
  • Mode: Root

Additional context

No response

Contributor guide

Tech stack
java
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid developmentAppManager codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how per app backup settings are stored and retrieved. Look at the code handling 'Redo existing backups' to understand why it does not reuse the original settings per app. The relevant files are likely in the backup module, such as BackupManager or related classes. Ensure that settings are persisted and reloaded for each app during a redo operation.