MultiAgentLearning/playground

Unit tests

Open

#108 opened on Jun 21, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (728 stars) (215 forks)batch import
help wanted

Description

I was looking for unit tests to understand corner cases + see how many of them are to port to C++. I haven't found any unit test of pommerman forward model logic.

It will be good to have at least regression tests when fixing bugs like: https://github.com/MultiAgentLearning/playground/commit/b16c395c347aa4f0ad0284e9e0e351c4bae413d2, https://github.com/MultiAgentLearning/playground/commit/3c06283f0906d72fd1a88850c4e00873baae4ba9, https://github.com/MultiAgentLearning/playground/commit/8b57431ebfe9e9894cc7766a780e3fc0a346e959.

Contributor guide

Tech stack
python
Domain
testingbackend
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Pythonpytestunderstanding of forward model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests unit tests for the pommerman forward model logic, referencing bug fix commits b16c395, 3c06283, and 8b57431. Start by examining those commits to understand the bugs and the forward model's behavior. Look at the existing code in the pommerman module to identify key functions and edge cases. Consider writing regression tests that replicate the bug scenarios. The issue has no recent activity, so confirm with maintainers if tests are still desired and what scope is acceptable.