MrSwitch/hello.js

Support on auth.error event

Open

#541 opened on Feb 17, 2018

View on GitHub
 (14 comments) (0 reactions) (1 assignee)JavaScript (4,630 stars) (557 forks)batch import
good first issuehelp wanted

Description

On page redirect authentication login is captured. However errors are not.

e.g. stored in localstorage would be...

{
	"adB2CSignInSignUp": {
		"error": {
			"code": "access_denied",
			"message": "AADB2C90118:+The+user+has+forgotten+their+password.\r\nCorrelation+ID:+3f341530-ed9a-4546-a646-2e2ac3e3b43d\r\nTimestamp:+2017-07-25+19:29:24Z\r\n"
		},
		"error_description": "AADB2C90118:+The+user+has+forgotten+their+password.\r\nCorrelation+ID:+3f341530-ed9a-4546-a646-2e2ac3e3b43d\r\nTimestamp:+2017-07-25+19:29:24Z\r\n",
		"state": "",
		"client_id": "da7caa3a-739c-436c-a32b-b428d3e8c043",
		"network": "adB2CSignInSignUp",
		"display": "page",
		"redirect_uri": "https://localhost:44369/redirect",
		"scope": "openid,https://foobar.onmicrosoft.com/foobarapi/use",
		"page_uri": "https://localhost:44369"
	}
}

This should trigger any listeners on auth.error on page load.

Contributor guide

Tech stack
javascriptrest api
Domain
authentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the existing event system in hello.js, specifically how `auth.login` and other events are triggered. Look at source files for the event emitter pattern. Review the issue comments for any proposed implementation details. No linked PR exists.