Miserlou/Zappa

Attempt to Import Event Sources - Warn if Function Does Not Exist

Open

#721 opened on Mar 15, 2017

View on GitHub
 (3 comments) (2 reactions) (0 assignees)Python (11,903 stars) (1,286 forks)batch import
help wanted

Description

Context

Feature Request to warn about typos.

In the zappa settings for events, If there are typos in event source function names, such as my recent use of a dash instead of an underscore, the error isn't apparent until zappa responds to the event and is unable to import the function used in response to the event.

Expected Behavior

For each event source in the stage, import the function to ensure it is reachable. Do this prior to uploading the zip. If the function is not reachable, raise an exception and message for the user.

"You have an event setup to call {{ function_name }}, but that that function cannot be imported. Please check for typos and ensure that the function is reachable."

Actual Behavior

Assumes function names are reachable.

Contributor guide

Tech stack
pythonaws
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonZappaAWS Lambdaevent sources
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine Zappa's CLI code, likely in `zappa/cli.py` or `zappa/core.py`, to find where event sources are parsed and the deployment zip is created. Add a check to import each event source function before uploading, raising an error if import fails. Look at existing tests in `tests/` for how similar features are tested.