Miserlou/Zappa

undeploy didn't nuke my apigw custom domain

Open

#698 opened on Mar 1, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Python (1,286 forks)batch import
bughacktoberfesthelp wanted

Repository metrics

Stars
 (11,903 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Context

I did a 'zappa undeploy production' for a project with a 'domain' set under 'production'.

Expected Behavior

I expected that to correctly remove the apigw entries that it created.

Actual Behavior

It removed the API-GW API, but not the 'Custom Domain Name' that it was using. The custom domain was 'emptied', however, in that it no longer listed any API Mappings, but I can't tell if that was Zappa doing its job or AWS nuking a reference to a no-longer-existing API entry.

Possible Fix

Your Environment

  • zappa --version => 0.37.1
  • linux (ubuntu 16.04)
  • python -V => 2.7.12

Contributor guide

Research direction
Investigate the Zappa undeploy function to see why it does not remove the API Gateway custom domain. Trace the code path for undeploy and check if there is a separate call to delete custom domains. Look for any related issues or pull requests.
Tech stack
python
Domain
backendapicloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonAWS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70