Miserlou/Zappa

Directories not excludable via zappa_settings.json

Open

#692 opened on Feb 26, 2017

View on GitHub
 (27 comments) (31 reactions) (0 assignees)Python (11,903 stars) (1,286 forks)batch import
help wanted

Description

Context

Directories not ignored as expected. The zappa_settings.json looks like this. Note that I am using .gitignore notation for ignoring the directories.

https://github.com/nueverest/vue_flask/blob/master/zappa_settings.json

{
    "production": {
        "s3_bucket": "nueverest",
        "aws_region": "us-west-2",
        "app_function": "vue_flask.app",
        "delete_local_zip": false,
        "exclude": ["deployed/", "static/", "unit_tests/", "*.css", "*.js", "*.json", "*.csv", "*.ico"]
    }
}

Expected Behavior

I am expecting the folders named: deployed, static, and unit_tests to be excluded from the generated zip file.

Actual Behavior

When I open the generated zip file I see the folders that I thought were excluded. This increases the time it takes to deploy the app.

Possible Fix

Allow directory patterns to be excluded via zappa_settings, or document how it is currently implemented in the readme.

Your Environment

Contributor guide

Tech stack
python
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonZappa framework basicsregular expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the exclude pattern handling in Zappa's build process, likely in the `zappa/cli.py` or `zappa/core.py` files. The issue is that directory patterns like 'deployed/' are not being excluded from the zip file. Check how the `exclude` list is parsed and applied to file globbing. Consider using Python's `fnmatch` or `pathlib` to properly match directories. Review the conversation in the issue for community suggestions.