inconsistent file encoding

Open
#131 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
networking

Research direction

Review revision 6ffca35 and the file lists in the issue, including the Telepathy, Telepathy.Tests, LoadTests, project, and documentation files. Normalize the listed files to ANSI while preserving Telepathy/VERSION as UTF-8, then verify that every file uses the intended encoding without changing its content.

Written by the indexing model from the issue text.

Description

Currently (revision 6ffca35) the source, project and text files are in different encodings - which is inconsistent and might be confusing.

I suggest to convert all files to ANSI encoding - except the file "VERSION" which cannot be converted to ANSI without loss because it includes Unicode-art (tableflips).

The following files are in ANSI encoding:

.gitignore
appveyor.yml
LICENSE
README.md
Telepathy.sln
LoadTests/LoadTest.csproj
Telepathy/ConnectionState.cs
Telepathy/MagnificentReceivePipe.cs
Telepathy/MagnificentSendPipe.cs
Telepathy/Pool.cs
Telepathy/Telepathy.csproj
Telepathy/ThreadFunctions.cs
Telepathy.Tests/MagnificentReceivePipeTests.cs
Telepathy.Tests/MagnificentSendPipeTests.cs
Telepathy.Tests/PoolTests.cs
Telepathy.Tests/UtilsTest.cs

The following files are in UTF-8 BOM encoding:

LoadTests/Main.cs
LoadTests/README.md
LoadTests/RunClients.cs
LoadTests/RunServer.cs
Telepathy/Client.cs
Telepathy/Common.cs
Telepathy/EventType.cs
Telepathy/Log.cs
Telepathy/NetworkStreamExtensions.cs
Telepathy/Server.cs
Telepathy/Utils.cs
Telepathy.Tests/TransportTest.cs
Telepathy.Tests/Telepathy.Tests.csproj

The following files are in UTF-8 encoding (no BOM):

Telepathy/VERSION

Dominant language
C#
Stars
1.2k
Forks
141
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MirrorNetworking/Telepathy

All issues in MirrorNetworking/Telepathy

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.