Invoke Dynamic instructions cannot be searched using ASMAPI
@Jonathing is already working on this.
Since Mar 2, 2025.
Assessment
This issue has not been assessed yet.
Description
ASMAPI has various helper methods that are meant to make traversing through bytecode easier. Unfortunately while working on CoreMods 5.2, I made an oversight where invoke dynamic expressions cannot be found using any of ASMAPI's findMethodCall methods, even though I have since added the ASMAPI.MethodType.DYNAMIC enum value.
This is not that big of a deal as I can search for invoke dynamic instructions the traditional way using for loops and checking the opcode. But for CoreMods 6.0, whether it will be in JS, Java, or embedded into some other system, this needs to be accounted for. This can probably by making the return value AbstractInsnNode and also accounting for invoke dynamic instructions as they also have a name and descriptor.
- Dominant language
- Java
- Stars
- 39
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MinecraftForge/coremods
-
MinecraftForge/coremods#74 · 1 assignee ·
-
MinecraftForge/coremods#68 · 1 assignee ·
All issues in MinecraftForge/coremods
Similar issues
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
inu-appcenter/memorIN-backend#288 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
frontend maui-pilot pilot-ask question
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
area/plugin
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
kestra-io/plugin-kestra#190 ·