TODO: Allow the use of fuzzy patching.
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
The issue names no files, tests, or entry points. Start by locating MCPConfig's existing patch application flow and comparing it with the primary Forge repo's fuzzy patching triggered by the Pupdating flag; done means patches can resolve shifted context and send unsuccessful applications to a rejects folder.
Written by the indexing model from the issue text.
Description
So, we're thinking about snapshots.
In the primary Forge repo, we're using fuzzy patching (triggered by the Pupdating flag) to help automate the resolution of most patches to a changed and shifted file.
It works by finding the closest context match (the surrounding area around a patch hunk) if there is no exact match to target. If there is no "close" match, the patch goes to a rejects folder for manual resolution by a human operator.
This would help greatly in MCPConfig, perhaps with a lower threshold for failed applications so that common fuzzy patching issues (such as duplicated lines) are less likely to happen.
Switching to fuzzy patching, combined with incremental patches (described in another issue) will mean that the 1.19-pre1 to 1.19-rc2 update would have roughly 3 files rather than roughly 60.
- Dominant language
- Java
- Stars
- 247
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MinecraftForge/MCPConfig
-
type: enhancement
Difficulty 5/5 Over a week Newbie friendliness 28/100
MinecraftForge/MCPConfig#171 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
MinecraftForge/MCPConfig#168 ·
All issues in MinecraftForge/MCPConfig
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
area/frontend
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100