SrgToMcpRenamer uses hardcoded path for nested jars

Open

#14 opened on Jul 5, 2023 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 48/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: java
Domain: tooling

Research direction

Inspect src/main/java/net/minecraftforge/installertools/SrgMcpRenamer.java around line 132, then read the linked JarJar metadata definition to understand how nested jar paths are represented relative to the outer jar. Done means SrgToMcpRenamer reads those metadata paths and deobfuscates nested jars regardless of their location, rather than assuming META-INF/jarjar/.

Written by the indexing model from the issue text.

Description

The Issue

Currently, only nested jars under the META-INF/jarjar/ directory are deobfuscated by SrgToMcpRenamer.

https://github.com/MinecraftForge/InstallerTools/blob/dd66a7d92e635e654ad356b7a18e56149e339539/src/main/java/net/minecraftforge/installertools/SrgMcpRenamer.java#L132

While this is the most common folder for nested jars, JarJar metadata defines nested jar paths as paths relative to the outer jar's root, and therefore nested jars can be located anywhere in the jar. This breaks mods that place their nested jars in other paths than the mentioned folder.

Expected behavior

SrgToMcpRenamer is able to deobfuscate any nested jars regardless of their location, as specified by JarJar metadata. Rather than assuming all nested jars are in the META-INF/jarjar/ directory, we should open the jar's JarJar metadata file and read nested jar paths from it.

Dominant language: Java
Stars: 6
Forks: 8
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug][UI] Change the method of opening the Action Detail Open

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

Netcracker/qubership-integration-platform#913 · Opened Sep 23, 2026
SEC-CORS-006 declares MEDIUM but can only emit HIGH or LOW Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

jdubois/boot-ui#1100 · Opened Sep 23, 2026
build-scan-xunit: accept ISO offset timestamps in test reports Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

elastic/gradle-plugins#157 · Opened Sep 23, 2026
OpenAPI document marks optional request body of `PUT /api/users/me` as required Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

cryptomator/hub#497 · Opened Sep 23, 2026
No test covers the claim that only the last command's state is checked Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

johanhaleby/occurrent#1120 · Opened Sep 23, 2026

More Java issues