[6.0] Generated methods CSV doesn't support record method names
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- build-system
Research direction
Start in src/mcp/java/net/minecraftforge/gradle/mcp/OfficialChannelProvider.java around lines 99–108 and inspect how method and field prefixes are classified. Check the generated method and field CSV output for record accessors such as NoiseGeneratorSettings.surfaceRule; done means those accessor methods are retained as methods and can be remapped at runtime.
Written by the indexing model from the issue text.
Description
Currently, the generator for method and field CSV files, OfficialChannelProvider, distinguishes methods and fields by their prefix, which is func_ / m_ for methods and field_ / f_ for fields. However, in records, the names of accessor methods are the same as the field they're accessing. As an example, see NoiseGeneratorSettings.surfaceRule.
This leads to all record method names being filtered out as fields by the generator.
When the mappings are later used at runtime by modlauncher for remapping class member names, record methods will never be remapped due to this issue.
- Dominant language
- Java
- Stars
- 574
- Forks
- 450
- Avg merge
- 16h 20m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MinecraftForge/ForgeGradle
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
MinecraftForge/ForgeGradle#1088 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
MinecraftForge/ForgeGradle#1087 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 50/100
MinecraftForge/ForgeGradle#1078 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
MinecraftForge/ForgeGradle#1076 ·
-
MinecraftForge/ForgeGradle#1058 · 12 comments · 1 assignee ·
All issues in MinecraftForge/ForgeGradle
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/cloudstack#14222 ·
-
[BUG]茶杯方块在取茶时会引发崩溃 Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
1.0.0-alpha2 Type/Improvement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
wso2/dpdp-accelerator#272 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
apache/rocketmq-dashboard#4860 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·