Mikhus/domurl

Relative protocol not honoured in IE

Open

#6 opened on Nov 11, 2013

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (100 forks)batch import
help wanted

Repository metrics

Stars
 (531 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

(Found in IE10)

new Url('//url-with-relative-protocol.co.uk/blah').toString();
// actual     ->  'url-with-relative-protocol.co.uk/blah'
// expected 1 ->  '//url-with-relative-protocol.co.uk/blah'
// expected 2 ->  [current page's protocol] + '//url-with-relative-protocol.co.uk/blah'

Contributor guide

Research direction
Examine the URL parsing code in domurl to see how it handles relative protocol (protocol relative URLs like '//example.com'). Check for any conditional logic that might strip the leading slashes or ignore protocol in IE. Consider cross browser testing and looking at existing browser URL behavior.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70