Mikhus/domurl

Relative protocol not honoured in IE

Open

#6 opened on Nov 11, 2013

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (531 stars) (100 forks)batch import
help wanted

Description

(Found in IE10)

new Url('//url-with-relative-protocol.co.uk/blah').toString();
// actual     ->  'url-with-relative-protocol.co.uk/blah'
// expected 1 ->  '//url-with-relative-protocol.co.uk/blah'
// expected 2 ->  [current page's protocol] + '//url-with-relative-protocol.co.uk/blah'

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptURL standards
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Look at the Url constructor and toString methods in the source code. The issue is that when encountering '//', the protocol is not preserved. Investigate how the library parses URLs, specifically the protocol portion. Consider adding a check for protocol relative URLs and prepending the current page's protocol from the environment.