Mikhus/domurl

query parameter with @ symbol not parsing correctly.

Open

#41 opened on Apr 1, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (531 stars) (100 forks)batch import
help wanted

Description

Try this out:

var url = new Url("http://example.com/some/path?a=b&c=test@someAnchor");

url.toString()
>>>"http://example.com%2Fsome%2Fpath%3Fa%3Db%26c%3Dtest@example.com/some/path?a=b&c=test%40someAnchor"

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of URL structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue demonstrates that the '@' character in a query parameter value is incorrectly interpreted as part of a URL anchor. Examine the library's parsing logic in lib/url.js, particularly the constructor or toString method that splits the query string. The current implementation likely splits on '@' before checking for query delimiters. A fix would involve properly escaping or preserving '@' within query parameter values. Check the existing test suite for similar edge cases.