Mikhus/domurl

query parameter with @ symbol not parsing correctly.

Open

#41 opened on Apr 1, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (100 forks)batch import
help wanted

Repository metrics

Stars
 (531 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Try this out:

var url = new Url("http://example.com/some/path?a=b&c=test@someAnchor");

url.toString()
>>>"http://example.com%2Fsome%2Fpath%3Fa%3Db%26c%3Dtest@example.com/some/path?a=b&c=test%40someAnchor"

Contributor guide

Research direction
Inspect the URL parsing logic in the source code to identify where the '@' symbol is mishandled during query parameter parsing, and trace how it affects the toString() output.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70