Mikhus/domurl

Hash is encoded but...

Open

#28 opened on Dec 6, 2016

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (531 stars) (100 forks)batch import
help wanted

Description

I dont know if it's the right behavior. I'm actually using backbone and the way to describe routes (like many front-end framework) is with hash like foo/1 which become foo%2F1 when using domurl to manipulate query parameters.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptURL encoding basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the domurl library's handling of hash fragments and URL encoding. The issue reports that forward slashes in hash routes (e.g., 'foo/1') are being percent encoded to '%2F' when using domurl to manipulate query parameters. Check the source code (likely in src/url.js or similar) for how query parameters and hash are parsed and serialized. Determine if the encoding is intentional or a bug. Consider whether the fix should preserve the original encoding of the hash or apply only to query parameters.