MiguelCatalan/MaterialSearchView

Bug: reveal animation doesn't always start from the search menu item

Open

#57 opened on Jan 20, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (3,821 stars) (627 forks)batch import
enhancementhelp wantedon hold

Description

modify the sample to have more action items on the right of the search menu item, and then click the search menu item. The reveal animation still starts from the most right area, instead of from the search menu item.

Here's an example of the modification that's needed to do it: menu_main.xml

<menu
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    tools:context=".MainActivity">
    <item
        android:id="@+id/action_search"
        android:icon="@drawable/ic_action_action_search"
        android:title="@string/abc_search_hint"
        app:showAsAction="always"/>
    <item
        android:icon="@android:drawable/ic_menu_edit"
        android:title="edit"
        app:showAsAction="always"/>
</menu>

Please fix this.

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android development basicsUnderstanding of Material Design SearchView
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the reveal animation implementation in the library, likely in the MaterialSearchView class or a utility class handling the search icon animation. The issue occurs when additional action items are present, so focus on how the animation origin is calculated. Check the code that determines the start position for the reveal effect, possibly related to the search menu item's position on the screen. Also examine any recent changes or linked comments for hints.