Detzection logic in Bundle.wxs seems wrong
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Domain
- build-system
Research direction
Open WebView2Samples/SampleApps/WV2DeploymentWiXBurnBundleSample/Bundle.wxs and inspect the util:RegistrySearch entry for the WebView2 registry key. Compare its Value attribute with the linked WebView2 distribution guidance and the reported installed registry value; done means the bundle detects an installed WebView2 runtime correctly.
Written by the indexing model from the issue text.
Description
To detect whether Webview2 is installed, WebView2Samples/SampleApps/WV2DeploymentWiXBurnBundleSample/Bundle.wxs uses
<util:RegistrySearch Root="HKLM" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Value="EBWebView" Variable="WVRTInstalled" Win64="no" />
According to https://docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution and my own experience, the value should however be "pv", not "EBWebView". i.e.
<util:RegistrySearch Root="HKLM" Key="SOFTWARE\Microsoft\EdgeUpdate\Clients\{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}" Value="pv" Variable="WVRTInstalled" Win64="no" />
- Dominant language
- C++
- Stars
- 1k
- Forks
- 521
- Avg merge
- 13m
- Merged PRs (30d)
- 1
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MicrosoftEdge/WebView2Samples
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 72/100
MicrosoftEdge/WebView2Samples#5 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
MicrosoftEdge/WebView2Samples#282 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MicrosoftEdge/WebView2Samples#277 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MicrosoftEdge/WebView2Samples#273 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
MicrosoftEdge/WebView2Samples#268 ·
All issues in MicrosoftEdge/WebView2Samples
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
hyprwm/aquamarine#426 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
amnezia-vpn/amnezia-client#3222 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
sdatkinson/NeuralAmpModelerCore#342 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
valkey-io/valkey-search#1465 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
KhronosGroup/Vulkan-Tutorial#524 ·
Maintainers usually reply within 1 day