Misleading visibility_timeout, Required vs optional parameters, updates needed!

Open Beginner friendly
#1,552 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
documentation

Research direction

Start with the linked QueueClient receive-message documentation and compare it with the referenced SDK corrections in commits 25f6410141c4613a8b48a8ebe8a22afac5ffe506 and e9d4668f61cb4705f488b041ff3e32abcb22ff19. Check the visibility_timeout wording and the required versus optional parameters for update_message and delete_message. Done means the published Python SDK documentation matches those corrections.

Written by the indexing model from the issue text.

Description

I see this correction on the sdk git but not on docs. Please update as needed.

https://docs.microsoft.com/en-us/python/api/azure-storage-queue/azure.storage.queue.queueclient?view=azure-python#azure-storage-queue-queueclient-receive-message

The PR and commit:

https://github.com/MicrosoftDocs/azure-docs-sdk-python/pull/1548

https://github.com/MicrosoftDocs/azure-docs-sdk-python/commit/25f6410141c4613a8b48a8ebe8a22afac5ffe506

Also, for update_message, pop_receipt and content don't need to be a required parameter. One place it says optional but another it says required. Details below:

image

WHY is it optional, because

  1. pop_receipt is already part of the message object. pop_receipt is only required if message object is not there like in case of cli and powershell.

  2. if we are issuing an update call for visibility_timeout alone, we do not need content as required parameter so it is optional.

Same for delete_message

image

Commit:

https://github.com/MicrosoftDocs/azure-docs-sdk-python/commit/e9d4668f61cb4705f488b041ff3e32abcb22ff19

Please review and approve if it looks good.

Dominant language
Python
Stars
172
Forks
258
Avg merge
1m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MicrosoftDocs/azure-docs-sdk-python

All issues in MicrosoftDocs/azure-docs-sdk-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.