Microsoft/vscode

Custom editors cannot be opened when a single-folder workspace has Been Extended To A Multi-Folder Workspace

Open

#98,603 opened on May 26, 2020

View on GitHub
 (3 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bugcustom-editorshelp wantedwebview

Description

  • VSCode Version: 1.45.1 / Insiders 2020-05-26T15:51:05.752Z
  • OS Version: Windows 10 / Mac

Steps to Reproduce:

  1. Check out Cat Customs Sample
  2. Install the extension
  3. Copy the exampleFiles folder to exampleFiles2
  4. Open a new VS Code Instance with exampleFiles as root folder
  5. (Custom Editor works as intended)
  6. Add exampleFiles2 to the workspace.
  7. Open example.cscratch in exampleFile2 folder.
  8. It crashes.

Does this issue occur when all extensions are disabled?: Yes

You can see this happening with my draw.io extension too: https://github.com/hediet/vscode-drawio/issues/61

Contributor guide

Tech stack
typescriptjavascriptnodejs
Domain
desktopdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VS Code extension APICustom editor conceptsWorkspace model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the custom editor provider lifecycle when transitioning from a single folder to a multi folder workspace. Look at the 'vscode extension samples/custom editor sample' for reproduction. Examine VS Code source code in 'src/vs/workbench/services/editor' and 'src/vs/platform/workspace' for handling workspace changes. The crash likely occurs due to incorrect URI handling or editor registration when additional folders are added. Check the draw.io extension issue for similar behavior.