Microsoft/vscode

No images in jsdoc hover or notebooks in remote/web

Open

#97,759 opened on May 13, 2020

View on GitHub
 (9 comments) (0 reactions) (2 assignees)TypeScript (74,848 stars) (10,221 forks)batch import
bughelp wantedjavascriptnotebook-workbench-integrationtypescriptweb

Description

  • Add an image in markdown syntax to a jsdoc comment
  • In a local vscode window, hover the identifier with the command
  • The image is rendered
  • Do the same in a remote window
  • The image is broken

Same issue with notebooks. @mjbvz Is it possible to hook into the same system that webviews use, or is that only tied to webviews?

Contributor guide

Tech stack
typescriptnodejselectron
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptElectronVS Code APIwebview
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how images are rendered in markdown hovers in local vs remote. Check the VS Code codebase for markdown rendering in src/vs/editor/contrib/hover/ and src/vs/workbench/contrib/webview/. Look at how webviews handle resource URIs. The issue asks about hooking into the webview system for remote images. Review any existing PRs or comments about image handling in remote contexts.
No images in jsdoc hover or notebooks in remote/web · Microsoft/vscode#97759 | Good First Issue