Microsoft/vscode

Custom editor autosave menubar state not updated properly

Open

#96,503 opened on Apr 29, 2020

View on GitHub
 (8 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bugcustom-editorshelp wanted

Description

Hi @mjbvz @jrieken,

I've been catching up with the daily updates, thanks for them btw. While working on our stuff, I've been noticing some issues on VSCode. Probably they're known issues but I'm sharing here in case they've been missed somehow. I'm able to reproduce them on both our code and this code.

Linux and Windows

  • [File -> Auto Save] Auto save enabled: "Save" is not triggered if you quickly (less than 1s) close the editor after making a change.

Linux-only

  • [File -> Auto Save] The "check" symbol is not shown when you enable "auto save" within the custom editor; however, the operation works.
  • [File -> Revert File] Sometimes the menu button is kept disabled when you start VSCode, even after changes.
  • [File -> Save All] Same behavior ^
  • [File -> Save] Same behavior ^; Ctrl+S works.
  • [File -> Save As] Same behavior ^; Ctrl+Shift+S works. note: the menu buttons become enabled when I open a text editor

Windows-only

  • [File -> Revert File] Can't use; always disabled.

Please let me know if you need any further information.

Originally posted by @caponetto in https://github.com/microsoft/vscode/issues/77131#issuecomment-620571200

Contributor guide

Tech stack
typescriptnodejselectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVSCode extension APICustom editor lifecycleMenu state management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the custom editor sample at https://github.com/mjbvz/vscode extension samples/tree/custom editor examples/custom editor sample. Look into VSCode source files related to menu state and autosave, such as `src/vs/editor/contrib/menu/menuActions.ts` and `src/vs/workbench/contrib/files/browser/autoSave.ts`. Check the current implementation of custom editor autosave event handling. Determine why the check symbol is not shown and why Save and other menu items remain disabled. Consider platform specific discrepancies (Linux vs Windows). The assignee may have additional context.