Microsoft/vscode

Git - VSCode locks git index in AFP repo

Open

#95,810 opened on Apr 22, 2020

View on GitHub
 (7 comments) (2 reactions) (1 assignee)TypeScript (10,221 forks)batch import
buggithelp wantedmacos

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VSCode Version: 1.43.2
  • OS Version: Darwin 18.7.0 Darwin Kernel Version 18.7.0: Mon Feb 10 21:08:45 PST 2020; root:xnu-4903.278.28~1/RELEASE_X86_64 x86_64 i386

Steps to Reproduce:

  1. Open workspace (in this case a LaTeX project)
  2. Attempt to run git add from a separate terminal window.

Result:

fatal: Unable to write new index file

Solution:

Close VSCode workspace.

VSCode appears to be keeping .git/refs/remotes/origin/master open. lsof doesn't indicate any locks but git still refuses to update the index until I close the VSCode window.

Contributor guide

Research direction
Investigate why VSCode holds file handles on the git index directory on AFP file systems. Check if the issue is related to file system event watching or git extension behavior. Consider testing with different file systems.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitBasic understanding of VSCode internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65