Microsoft/vscode

Git - Git Typechanges do not appear in source control panel

Open

#91,100 opened on Feb 20, 2020

View on GitHub
 (4 comments) (1 reaction) (1 assignee)TypeScript (10,221 forks)batch import
buggithelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Issue Type: Bug

The source control panel does not display files where git has detected that the type has changed, such as when an actual file replaces a symlink.

  1. Create a file and a symlink to the file in a git repository. (git init; touch default_img; ln -s default_img john_smith_headshot)
  2. Commit both the files. (git commit -m 'Commit default image for use until actual photos arrive')
  3. Replace the symlink with an actual, distinct file. (mv some_other_image john_smith_headshot)
  4. Run git status. Note that git detects the typechange (git status) Expected behaviour: The file which replaced the symlink appears in the source control panel, marked as T for typechange Actual behaviour: Panel remains empty

VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:50:36.977Z) OS version: Linux x64 5.3.0-40-generic

Item Value
CPUs Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2922)
GPU Status 2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 15.52GB (9.33GB free)
Process Argv --disable-extensions . --no-sandbox
Screen Reader no
VM 0%

Contributor guide

Research direction
Investigate how the source control panel processes git status changes. Look for where file change types are parsed and check if typechange (T) is handled. Refer to the git extension code in VS Code repository.
Tech stack
typescriptjavascriptelectron
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60