Microsoft/vscode

[css] Support for SVG 2 CSS Properties

Open

#85,828 opened on Nov 29, 2019

View on GitHub
 (18 comments) (23 reactions) (1 assignee)TypeScript (10,221 forks)batch import
css-less-scssfeature-requesthelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

SVG 2 introduces the possibility of setting SVG properties in CSS (see CSS Tricks' post under "Element-specific properties -> "Positioning SVG elements"). This means this example should be valid:

circle {
  r: 2;
  cx: 10;
  cy: 100;
}

path {
  d: 'L0 100';
}

However, these properties trigger the s?css(unknownProperties) warning:

image

I'm not too familiar with VS Code's insides and what program checks for valid properties. If this belongs somewhere else, I'd be happy to re-issue there.

Thanks! ✨

Contributor guide

Research direction
Locate where CSS property validation is implemented in VS Code (likely in the CSS language service or in the built in CSS extension), then add SVG 2 element specific properties (e.g., 'cx', 'cy', 'r', 'd') to the list of recognized CSS properties. Check the CSS custom data format if needed.
Tech stack
typescriptcss
Domain
developer experiencefrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70