Microsoft/vscode

Incorrect keyboard shortcut shown in menu.

Open

#85,798 opened on Nov 29, 2019

View on GitHub
 (6 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bugchromiumconfirmedhelp wantedlinuxmenusupstream

Description

  • VSCode Version: 1.40.2 (also happens in 1.41.0-insider)
  • OS Version: Pop!_OS 19.10 64-bit (which is very much like Ubuntu 19.10 Eoan Ermine)

Steps to Reproduce:

  1. Press Ctrl+K, Ctrl+S to open the keyboard shortcut editor;
  2. Find the entry for toggling the Activity Bar (workbench.action.toggleActivityBarVisibility)
  3. Set its keybinding to "Ctrl + Super + A", which shouldn't be used by anything else by default; "Super" is the "Windows" key on PC keyboards, also known as the meta key in Linux.
  4. Close the keyboard shortcut editor;
  5. Open the "View" menu --> "Appearance"
  6. See that the keyboard shortcut displayed next to "Show Activity Bar" is "Ctrl+A" instead of "Ctrl+Super+A"

Does this issue occur when all extensions are disabled?: Yes

Contributor guide

Tech stack
typescriptjavascriptelectron
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic TypeScriptVSCode keybinding APIElectron menu systemLarge codebase navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the menu rendering code in VSCode's workbench, specifically the part that displays keyboard shortcuts next to menu items. The issue relates to the command 'workbench.action.toggleActivityBarVisibility'. Look at files like 'src/vs/workbench/services/keybinding/browser/keybindingServiceImpl.ts' or the menu widget. Ensure that when a keybinding is customized, the menu displays the correct shortcut. Check if there is a discrepancy between the stored keybinding and the displayed one in the menu's label.