Microsoft/vscode

Incorrect keyboard shortcut shown in menu.

Open

#85,798 opened on Nov 29, 2019

View on GitHub
 (6 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugchromiumconfirmedhelp wantedlinuxmenusupstream

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VSCode Version: 1.40.2 (also happens in 1.41.0-insider)
  • OS Version: Pop!_OS 19.10 64-bit (which is very much like Ubuntu 19.10 Eoan Ermine)

Steps to Reproduce:

  1. Press Ctrl+K, Ctrl+S to open the keyboard shortcut editor;
  2. Find the entry for toggling the Activity Bar (workbench.action.toggleActivityBarVisibility)
  3. Set its keybinding to "Ctrl + Super + A", which shouldn't be used by anything else by default; "Super" is the "Windows" key on PC keyboards, also known as the meta key in Linux.
  4. Close the keyboard shortcut editor;
  5. Open the "View" menu --> "Appearance"
  6. See that the keyboard shortcut displayed next to "Show Activity Bar" is "Ctrl+A" instead of "Ctrl+Super+A"

Does this issue occur when all extensions are disabled?: Yes

Contributor guide

Research direction
Trace how keybindings are resolved and displayed in the menu component. Check the keybinding service and the menu rendering code to understand why the shortcut for `workbench.action.toggleActivityBarVisibility` shows 'Ctrl+A' instead of 'Ctrl+Super+A'.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70