Microsoft/vscode

Menu widget rendered in greyscale

Open

#75,615 opened on Jun 17, 2019

View on GitHub
 (38 comments) (1 reaction) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bugchromiumfont-renderinghelp wantedlcd-text-renderingmenus

Description

Version: 1.35.1 (user setup) Commit: c7d83e57cd18f18026a8162d042843bda1bcf21f Date: 2019-06-12T14:30:02.622Z Electron: 3.1.8 Chrome: 66.0.3359.181 Node.js: 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.18362

I also double checked that the problem is on the Insider's Build.

Steps to Reproduce:

  1. Observe text on screen. It should have gray subpixel rendering. 1
  2. Open menu bar.
  3. Observe text on screen. It should have RGB subpixel rendering. 2

This issue occurs on all text (except the menu bar submenus). I noticed it, because the text rendering looks better, but only when the menu bar was open! I would prefer all of it to use RGB subpixel rendering, like my other applications.

Does this issue occur when all extensions are disabled?: Yes

Contributor guide

Tech stack
typescriptcsselectron
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of subpixel renderingFamiliarity with Electron and Chromium internalsExperience with VS Code codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
Review the existing comments on the issue (#75615) for any proposed solutions or debugging attempts. Look into VS Code's main process and renderer code, particularly the CSS styles related to text rendering and the Electron shell's text rendering settings. Since this bug involves subpixel rendering differences when the menu bar is open, investigate how the menu widget might affect the overall rendering context of the application.
Menu widget rendered in greyscale · Microsoft/vscode#75615 | Good First Issue