Microsoft/vscode

Git - .gitignore'd files sometimes not greyed-out

Open

#70,963 opened on Mar 22, 2019

View on GitHub
 (73 comments) (41 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
buggithelp wanted

Description

Hi 👋

Sometimes files and folders that are in .gitignore and normally greyed-out just stop being greyed-out. #70099 may be related, see how in the first image in comment https://github.com/Microsoft/vscode/issues/70099#issuecomment-471596614 node_modules directory is not greyed out, however in the second one it is properly greyed-out again.

Here is a quick gif (I do ⌘⇧P — Reload window in the middle of it):

hello

Unfortunately, cannot reproduce 😞

  • VSCode Version: 1.32.3
  • OS Version: 10.14.3

Contributor guide

Tech stack
typescriptcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
TypeScriptVS Code source code structureUnderstanding of Git integration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the Git extension's decoration provider in VS Code, likely in `extensions/git/src/decorationProvider.ts`. Focus on how it determines gitignored files and why the greyed out style may not apply. Review related issue #70099 for additional context. Since the bug is intermittent, consider adding trace logging to capture state when decorations fail.