Microsoft/vscode

[json] add commas automatically

Open

#69,545 opened on Feb 27, 2019

View on GitHub
 (12 comments) (26 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedjson

Description

Test case

untitledb2

Expected behavior

  • After typing age TAB, the comma should be added to the end of the previous line.
  • After typing " for the next object property, the comma should be added to the end of the previous line.

Actual behavior

The autocomplete does not produce valid text.

Discussion

In general, the autocomplete should strive to produce output that is maximally valid in whatever language grammar it is using.

Contributor guide

Tech stack
typescript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of VSCode extension APIFamiliarity with JSON grammar
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue requests automatic comma insertion during JSON autocomplete. The core behavior likely resides in the JSON language extension under extensions/json/. Investigate the CompletionItemProvider implementation and how it constructs text edits. Review the 12 comments for any implementation hints or concerns raised by maintainers. Since the issue has an assignee, check if there is an existing branch or planned work to avoid duplication.