Microsoft/vscode

Git - Gracefully handle git hooks

Open

#64,409 opened on Dec 5, 2018

View on GitHub
 (4 comments) (44 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requestgithelp wanted

Description

Most projects will have some form of precommit hooks for linting or tests through libraries such as lint-staged and husky.

When committing via the source control panel in VSCode there's no visual indicator for when a git hook is running. I think this could be an opportunity to put some UI indicator around this.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of VS Code extension APIUnderstanding of git hooksBasic TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate how VS Code's source control panel currently displays git operations. Look at the extension host's git implementation in 'extensions/git/' to understand where hooks are executed. Consider adding a progress indicator similar to other long running operations (e.g., 'git fetch'). Review existing discussions in the issue for potential UI designs.
Git - Gracefully handle git hooks · Microsoft/vscode#64409 | Good First Issue