Microsoft/vscode

[folding] Move line up/down should skip over folded regions or folded sections

Open

#63,972 opened on Nov 29, 2018

View on GitHub
 (14 comments) (75 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
editor-commandseditor-foldingfeature-requesthelp wanted

Description

  • VSCode Version:1.30.0-insider
  • OS Version: windows 10

I think when code is in a folded region or section it should never unfold unless explicitly commanded, so if you are moving a line using move command, the line should skip over both folded regions and folded sections Steps to Reproduce:

  1. create a folded region using #region #endregion
  2. fold some code section
  3. move a line using alt+up/down over the folded region/section vscodemovelinebug

Does this issue occur when all extensions are disabled?: Yes

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VS Code editor architectureFolding APILine move commands
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the move line command implementation in the VS Code editor, specifically the `editor.action.moveLinesUpAction` and `editor.action.moveLinesDownAction`. Examine how folding regions are handled in the `FoldingController` and `FoldingRangeProvider`. Review existing comments for potential approaches, such as skipping fold ranges during selection. Consider whether to modify the `MoveLinesCommand` or add a new option to avoid unfolding.