Microsoft/vscode

Use the modifier properties on mouse event instead of tracking keydown/keyup

Open

#58,515 opened on Sep 12, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (10,221 forks)batch import
debteditor-drag-and-drophelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Extracted from our conversation at https://github.com/Microsoft/vscode/commit/e82498a544b88f5041ec7f8b531ab8ca6eb29eaf

Contributor guide

Research direction
Identify mouse event handlers in the codebase that use separate keydown/keyup tracking and replace them with the modifier properties (e.g., event.altKey, event.ctrlKey) to simplify the code.
Tech stack
typescript
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65