Microsoft/vscode

Use the modifier properties on mouse event instead of tracking keydown/keyup

Open

#58,515 opened on Sep 12, 2018

View on GitHub
 (1 comment) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
debteditor-drag-and-drophelp wanted

Description

Extracted from our conversation at https://github.com/Microsoft/vscode/commit/e82498a544b88f5041ec7f8b531ab8ca6eb29eaf

Contributor guide

Tech stack
typescript
Domain
desktopfrontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptevent handlingVSCode codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Study the linked commit (e82498a544b88f5041ec7f8b531ab8ca6eb29eaf) to understand the context. Search the VSCode codebase for manual keydown/keyup tracking of modifier keys in mouse event handlers. Replace with native MouseEvent modifier properties (ctrlKey, shiftKey, altKey, metaKey). Focus on the editor module, likely files in src/editor. Update associated tests. Coordinate with the assignee if needed.