Microsoft/vscode

Add settings editor commands to focus next and previous settings

Open

#52,815 opened on Jun 25, 2018

View on GitHub
 (7 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedsettings-editor

Description

Issue Type: Bug

  1. When the cursor in the search box, DownArrow moves the keyboard focus to the list of settings. However, UpArrow does not bring me back to the search box.

  2. When the keyboard focus in the TOC, RightArrow should move the keyboard focus to the closest item in the list of settings.

  3. When the keyboard focus is in the list of settings, LeftArrow should move the keyboard focus to the highlighted node in the TOC.

  4. It seems unusal that the section headers and subheaders in the list of settings can take the keyboard focus. It would feel more natural if the headers and subheaders would be skipped.

  5. When a settings cells has the keyboard focus, Enter should move the keyboard focus to the value editor (same as Tab. Shift+Tab and ESC remain to remove it back to the settings row.

VS Code version: Code - Insiders 1.25.0-insider (5d6156a0f8b68fe7e9429facbcfaa7c061a8b3e3, 2018-06-25T09:32:08.937Z) OS version: Darwin x64 16.7.0

Item Value
CPUs Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status 2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (1.06GB free)
Process Argv /Users/kmaetzel/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_17449123
Screen Reader no
VM 0%

Contributor guide

Tech stack
typescripthtmlcss
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptAccessibility basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the existing keyboard event handlers in the settings editor component, likely located in src/vs/workbench/contrib/preferences/. Determine how focus moves between the search input, table of contents (TOC), and settings list. Implement the missing UpArrow focus return to search box, RightArrow to settings list from TOC, LeftArrow to TOC from settings list, skipping headers, and Enter to open value editor. Review the issue comments for any additional context or maintainer insights.