Microsoft/vscode

Cannot exclude root folders while searching

Open

#50,638 opened on May 29, 2018

View on GitHub
 (14 comments) (20 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedsearch

Description

Testing #50498

  • In a MR workspace, try to exclude root folder using /folder1/ and search. Results are still shown in folder1.

This happens irrespective of setting search.enableSearchProviders"

image

Contributor guide

Tech stack
typescript
Domain
desktopsearch
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VS Code search basicsglob patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the search exclusion logic in the VS Code search extension. Check the implementation of glob pattern matching in the search service, particularly for root folder exclusions. Review comments in the issue for any additional context or partial fixes.