Microsoft/vscode

[Emmet] Include should be more like DocumentSelector

Open

#49,588 opened on May 10, 2018

View on GitHub
 (11 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
emmetfeature-requesthelp wanted

Description

Currently, the Emmet extension has a setting called emmet.includeLanguages which just targets language IDs to map to the Emmet-capable language ID. I think it would be very useful if instead you could use something more like DocumentSelector, which also allows DocumentFilter instead of just language ID.

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VSCode extension APIEmmet extension internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
This issue is assigned to a maintainer. The change requires modifying the `emmet.includeLanguages` setting in `extensions/emmet/package.json` and the corresponding activation logic in `extensions/emmet/src/` to support `DocumentSelector` objects. Review the VSCode API documentation for `DocumentFilter` and `DocumentSelector` to understand the new structure. The existing comments provide some discussion on possible approaches. Ensure backward compatibility with the current string only format.