Microsoft/vscode

[Emmet] Include should be more like DocumentSelector

Open

#49,588 opened on May 10, 2018

View on GitHub
 (11 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
emmetfeature-requesthelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Currently, the Emmet extension has a setting called emmet.includeLanguages which just targets language IDs to map to the Emmet-capable language ID. I think it would be very useful if instead you could use something more like DocumentSelector, which also allows DocumentFilter instead of just language ID.

Contributor guide

Research direction
Study the vscode extension API for DocumentSelector and DocumentFilter, then modify the emmet extension to accept DocumentFilter in the includeLanguages setting.
Tech stack
typescript
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGitVS Code Extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65