Microsoft/vscode

SCM - Support keyboard shortcuts for inline change review commands

Open

#38,113 opened on Nov 11, 2017

View on GitHub
 (5 comments) (8 reactions) (1 assignee)TypeScript (10,221 forks)batch import
feature-requesthelp wantedscm

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Steps to Reproduce:

  1. Set this in keybindings
{
    "key": "alt+cmd+z",
    "command": "git.revertChange"
}

revert-changes

Reproduces without extensions: Yes

Contributor guide

Research direction
Investigate the keybinding handler for `git.revertChange` and trace the command execution path to find why the shortcut does not trigger the inline change review.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70