Microsoft/vscode

Add control to open file shown in "replace preview" editor when performing project-wide find/replace

Open

#35,337 opened on Sep 28, 2017

View on GitHub
 (15 comments) (10 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
feature-requesthelp wantedsearch

Description

While performing a project-wide find/replace, opening an occurrence from the search sidebar opens a "replace preview" diff editor. This view is not editable, so if the user would like to edit the displayed file, the only current way to do so is manually either from the explorer sidebar or the quick-open palette.

Per @roblourens' suggestion in #35323, "There should be a working Open File button that always appears, git repo or not, in the replace diff editor."

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVSCode development environment setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Review the related issue #35323 and the current implementation of the replace preview editor in the VSCode source code. The relevant files are likely in the 'src/vs/editor/contrib/find' directory. Focus on the diff editor component that displays the replace preview. The goal is to add an 'Open File' button that opens the file being edited. Check comments from @roblourens for design suggestions. Ensure the button works regardless of Git status.