Microsoft/vscode

[html] provide rename for embedded JavaScript

Open

#31,141 opened on Jul 20, 2017

View on GitHub
 (6 comments) (14 reactions) (2 assignees)TypeScript (10,221 forks)batch import
feature-requesthelp wantedhtmljavascriptkeep

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VSCode Version: v1.14.1
  • OS Version: macOS Sierra v10.12.6
  • Reproduces without extensions: Yes

Steps to Reproduce:

  1. Create these two files:

my-custom-element.js

class MyCustomElement extends HTMLElement {
  static get is() {
    return 'my-custom-element';
  }
}

customElements.define(MyCustomElement.is, MyCustomElement);

my-custom-element.html

<script>
  class MyCustomElement extends HTMLElement {
    static get is() {
      return 'my-custom-element';
    }
  }

  customElements.define(MyCustomElement.is, MyCustomElement);
</script>
  1. Try the Rename Refactoring with F2 in both files:

With the same code, the "Rename Refactoring" doesn't work in HTML language.

Contributor guide

Research direction
Investigate the HTML language service's rename provider to add support for JavaScript embedded in script tags. Look at how the JavaScript language service handles rename and integrate it.
Tech stack
typescriptjavascripthtml
Domain
developer experiencetoolingfrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60