Microsoft/vscode

Discard changes of an Untracked file raise an error if no recycle bin option

Open

#246259 opened on Apr 10, 2025

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
buggithelp wantedteam-low-hanging

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. Set the Recycle Bin option to Delete directly
  2. Try to undo the changes of an untracked file
  3. You'll get an error cause VSCode should put that file into the bin, but with that option set, can't delete the file

Image Image

Contributor guide

Tech stack
typescriptnodejselectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with VS Code file operationsUnderstanding of recycle bin setting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the source code for the discard changes action on untracked files, specifically in the file service or explorer view. Look for where the recycle bin option is checked. The bug report indicates that when the recycle bin is set to 'Delete directly', the code still attempts to use the recycle bin, causing an error. Search for functions that handle file deletion and check the setting 'files.enableTrash'. Verify the logic and suggest a fix to respect the setting.