Microsoft/vscode

Incorrect TerminalShellExecution exit code

Open

#237,517 opened on Jan 8, 2025

View on GitHub
 (3 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedterminal-shell-bash

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.94.0
  • OS Version: macOS Sonoma 14.4

Steps to Reproduce:

  1. Listen for onDidEndTerminalShellExecution events
  2. Run a command that returns some exit code
  3. Type the same command and interrupt with ^C (i.e. interrupt without actually running the command)
  4. The exit code reported by the TerminalShellExecution event for the second execution (expected to be undefined since the command didn't actually run) will be the same as the previous command's exit code

For example:

$ echo test^C
-> exit code undefined
$ echo test
-> exit code 0
$ echo test^C
-> exit code 0
$ echo test^C
-> exit code 0
$ echo not test^C
-> exit code undefined
$ echo test^C
-> exit code undefined

From a quick look, this seems like caused by this code (marked as a hack): https://github.com/microsoft/vscode/blob/3b30f94f4f129e67be9b6c677aac582923da1fab/src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts#L360-L370

Contributor guide

Research direction
Inspect the hack in commandDetectionCapability.ts around line 360-370 and trace the exit code handling path to understand why the exit code is incorrectly reused from the previous command.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75