Microsoft/vscode

Clicking URLs in terminal while connecting are opened only after connecting

Open

#236,398 opened on May 3, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugconfirmation-pendinghelp wantedremoteterminal-links

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

  • VSCode Version: 1.88.1
  • Local OS Version: Linux x64 6.5.0-28-generic
  • Remote OS Version: Linux 4.18.0-513.24.1.el8_9.x86_64 x86_64
  • Remote Extension/Connection Type: Server

I'm not sure which of the remote development plugins causes this, that's why I'm opening a general issue. Apologies if this is the wrong spot.

The remote machine I'm connecting to requires 2FA. The terminal shows a URL to visit, which handles the 2FA procedure. The problem is that when I CTRL+click on the URL, it doesn't open. It only opens after the procedure is done. I assume there is some blocking / waiting going that doesn't allow this event to go through directly.

  • Logs:
Logging in as <username> from <redacted>.
Please open https://<2fa_link> to complete logon.

Steps to Reproduce:

  1. Try to connect to machine.
  2. Get prompted to go to 2FA link.
  3. Click link.
  4. Nothing happens.
  5. Copy link manually and complete 2FA procedure.
  6. Setup continues as normal.
  7. The link opens (from the original click).

Does this issue occur when you try this locally?: No Does this issue occur when you try this locally and all extensions are disabled?: No

Contributor guide

Research direction
Investigate the remote connection flow and terminal link opening mechanism. The issue is that URL clicks in the terminal are deferred until after the connection completes, likely due to a blocking operation or event queue. Check the code that handles terminal link clicks and the remote connection lifecycle.
Tech stack
typescript
Domain
developer experiencebackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
VSCode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60