Microsoft/vscode

Missing support for asymmetric visibility when using PHP constructor property promotion

Open

#235,765 opened on Dec 10, 2024

View on GitHub
 (1 comment) (1 reaction) (1 assignee)TypeScript (10,221 forks)batch import
feature-requestgrammarhelp wantedphp

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.95.3
  • OS Version: macOS 15.1.1

Steps to Reproduce:

With asymmetric visibility Image

Without asymmetric visibility Image

The scope becomes

meta.function.parameters.php
meta.function.php
meta.class.body.php
meta.class.php
source.php
meta.embedded.block.php
text.html.php

when using asymmetric visibility instead of

storage.modifier.php
meta.function.parameter.promoted-property.php
meta.function.parameters.php
meta.function.php
meta.class.body.php
meta.class.php
source.php
meta.embedded.block.php
text.html.php

Contributor guide

Research direction
Look at the PHP TextMate grammar files in vscode and add the required scopes for asymmetric visibility modifiers in constructor promotion.
Tech stack
typescriptphp
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75