Microsoft/vscode

`notebook.addFindMatchToSelection` needs one extra invocation

Open

#235,123 opened on Dec 3, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugeditor-highlighthelp wantednotebook-cell-editor

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Testing #235047

When pressing Cmd D in a regular editor after selecting a word, the next find match will be added to the selection.

🐛 In notebooks, the first Cmd D will do nothing. Only the second one will select the next find match.

Contributor guide

Research direction
Investigate the find match selection behavior in notebook editors to understand why the first invocation of Cmd D (or Ctrl D) does nothing, while the second invocation selects the next find match. Look at how `addFindMatchToSelection` is implemented in notebook context compared to regular editors.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70