Microsoft/vscode

Contributing a text editor provider raises warning, even when user selects it as 'workbench.editor.defaultBinaryEditor'

Open

#230,179 opened on Sep 30, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugcustom-editorshelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Contributing a 'CustomTextEditorProvider', to be selected by the user as 'workbench.editor.defaultBinaryEditor' still raises the warning of 'File seems to be binary and cannot be opened as text'

Context: We are currently developing a VSCode extension, to parse binaries with objdump and provide the information about the binary. We need the output to be presented in a text editor, not a custom editor as we are contributing a new language model for objdump output. So, mainly we need the output syntax coloring, as document symbols to be provided, which is not possible in the custom editor WebView.

We need a way to bypass the warning, as the user selects the provided custom text editor as the default binary editor.

Related Discussion

Contributor guide

Research direction
Investigate the code that shows the warning 'File seems to be binary and cannot be opened as text'. Ensure that if 'workbench.editor.defaultBinaryEditor' is set to a custom text editor provider, the warning is suppressed. Trace the handler path from the editor opening to the binary detection logic.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60