Microsoft/vscode

Undo stacks are not granular enough for Korean

Open

#229,647 opened on Sep 25, 2024

View on GitHub
 (3 comments) (2 reactions) (2 assignees)TypeScript (10,221 forks)batch import
editor-input-IMEfeature-requesthelp wantedundo-redo

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Testing #229383

Right now, typing a sentence in Korean and pressing undo will remove the entire line. I confirmed with a native Korean speaker that the ideal behavior for undo is to remove the last consonant/vowel (each character is made up of 2-4 consonants/vowels). This might be difficult to do depending on how EditContext words, but a little less better but much better than deleting the whole line is to delete the last fully formed character.

Image

Note that this is not a regression, but it's a pretty bad existing great experience.

Contributor guide

Research direction
Investigate how VSCode's undo stack handles input method editor (IME) composition for Korean. Look for the undo command implementation and test with Korean characters.
Tech stack
typescriptjavascript
Domain
developer experiencedesktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30