Microsoft/vscode

ctrl+z / ctrl+shift+z (undo/redo) not working for input elements when a custom editor is open

Open

#227,849 opened on Sep 6, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugcustom-editorshelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes (affects extension authoring)

  • VS Code Version: 1.94.0-insider
  • OS Version: Mac Sonoma 14.6.1

Steps to Reproduce:

  1. Modify webview-view-sample's webview HTML to include an <input> element

  2. Compile and package the webview extension (will need to modify the publisher tag), then install it locally

  3. Compile and run the custom-editor-sample

  4. Open the calico colors webview view

  5. Observe that when no custom editors are open, the ctrl+z / ctrl+shift+z events work

  6. Open the custom editor

  7. Observe that the undo/redo hotkeys no longer work in the webview view

Contributor guide

Research direction
Investigate how keybindings are dispatched when custom editors and webview views are open. Check the focus order and event propagation for ctrl+z inside input elements.
Tech stack
typescript
Domain
desktopdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
JavaScriptTypeScriptVS Code extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50