Microsoft/vscode

File menu save commands get unexpectedly disabled when using a custom editor

Open

#219,807 opened on Jul 2, 2024

View on GitHub
 (0 comments) (1 reaction) (1 assignee)TypeScript (10,221 forks)batch import
bugcustom-editorshelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

https://github.com/microsoft/vscode/assets/6801309/2954ead6-27ff-48f9-a5a5-5c3273a2643a

Does this issue occur when all extensions are disabled?: N/A this is an extension issue.

  • VS Code Version: 1.90.2
  • OS Version: macOS + Windows

Steps to Reproduce:

  1. Open a custom editor
  2. Observation: Save commands are enabled in the file menu
  3. Focus to another editor
  4. Focus back to the custom editor
  5. Observation: Save commands are now disabled in the file menu

Contributor guide

Research direction
Investigate the logic that enables/disables save commands in the file menu. Focus on the custom editor's focus handling and how command enablement is updated when switching between editors.
Tech stack
typescript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70