Microsoft/vscode

Go to definition opens another code editor if custom editor is opened

Open

#215,589 opened on Jun 14, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugcustom-editorshelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Type: Bug

Conext: I have my language server implemented, which reacts to textDocument/definition. It works great for code editors.

Issue description: If I "go to definition" of a variable expression it's opening up a new code editor of the file that I already have open... It is happening in my default setup of having split screen of code editor and custom editor for the same file.

VS Code version: Code 1.90.1 (Universal) (611f9bfce64f25108829dd295f54a6894e87339d, 2024-06-11T21:02:41.372Z) OS version: Darwin arm64 22.6.0

Contributor guide

Research direction
Investigate the 'go to definition' command handler in VS Code's source code. Look at how it determines which editor to use, especially when a custom editor is already open. The logic might be in the editor group service or the text model resolver. Check for any conditions that cause a new editor to open instead of reusing the existing one.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptVS Code extension API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65