Microsoft/vscode

Parentheses `()` and square brackets `[]` in file names can break terminal links (eg. next.js dynamic file paths)

Open

#212,109 opened on May 6, 2024

View on GitHub
 (6 comments) (3 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bugconfirmedhelp wantedterminal-links

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.89.0
  • OS Version: macOS Sonoma 14.4.1

This issue was supposedly fixed in #169774, but it still doesn't seem to be working for me. Maybe a regression?

When the terminals logs file names that include characters ()[] (Used by NextJS routing segments for example), it splits the file name into multiple parts and is not properly clickable to open that file.

Steps to Reproduce:

In the integrated terminal, run echo "./src/(hello)/[world]/file.tsx" and hover over the output while holding cmd to see the different file segments determined by VSCode. Should look something like:

./src/(hello)/[world]/file.tsx
------ ----- - ----- ---------

Contributor guide

Research direction
Examine the terminal link detection logic in VS Code's terminal extension (likely in `src/vs/workbench/contrib/terminal/browser/linkDetector.ts` or similar). Review the previous fix for #169774 to understand the regex or parsing approach used for file paths. Focus on ensuring that parentheses `()` and square brackets `[]` are correctly handled as part of the filename. Trace the test cases for link detection to see if they cover these characters. Debug by running the integrated terminal with a path containing these characters and observe the link regions.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70