Microsoft/vscode

[A11y] Focus changes to custom editor when clicking on notebook toolbar overflow menu

Open

#210,627 opened on Apr 18, 2024

View on GitHub
 (1 comment) (2 reactions) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedwebview

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Does this issue occur when all extensions are disabled?: No (requires custom editor)

  • VS Code Version: 1.89.0-insider
  • OS Version: Mac Sonoma 14.4.1

Steps to Reproduce:

  1. Run the custom-editor-sample in the extension samples repository and open a .pawDraw or .cscratch file

  2. Create a new notebook editor (ipynb file) in side by side orientation

  3. First focus the notebook and observe that the tab title is highlighted

  4. Now click the toolbar overflow button and observe that the custom editor tab is now highlighted

The focus should not change here but it does.

Contributor guide

Research direction
Investigate the focus event logic when clicking the notebook toolbar overflow menu. Trace the focus change from the notebook tab to the custom editor tab. Look for event handlers that might unintentionally transfer focus. Check the custom editor's focus handling and the notebook's overflow menu implementation.
Tech stack
typescript
Domain
desktop
Issue type
Accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
VS Code extension developmentaccessibility standards
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30