Microsoft/vscode

code serve web --server-base-path PWA app does not include base path

Open

#209,601 opened on Apr 5, 2024

View on GitHub
 (4 comments) (1 reaction) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bughelp wantedremote

Description

When we run vscode as code serve-web with the new option server-base-path, then PWA app doesn't work properly because it doesn't use the path(tested in chrome and edge).

Contributor guide

Tech stack
typescriptnodejs
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
familiarity with VSCode's code serve web featurebasic understanding of progressive web apps
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue reports that when using `code serve web server base path`, the PWA app does not include the base path. To fix, examine how the PWA service worker is registered in the web server variant. Look at files in `src/vs/server/` and the web shell. Ensure the base path is injected into the service worker registration URL. Check comments in the issue for any specific reproduction steps or maintainer guidance.
code serve web --server-base-path PWA app does not include base path · Microsoft/vscode#209601 | Good First Issue