Microsoft/vscode

code serve web --server-base-path PWA app does not include base path

Open

#209,601 opened on Apr 5, 2024

View on GitHub
 (4 comments) (1 reaction) (1 assignee)TypeScript (10,221 forks)batch import
bughelp wantedremote

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

When we run vscode as code serve-web with the new option server-base-path, then PWA app doesn't work properly because it doesn't use the path(tested in chrome and edge).

Contributor guide

Research direction
Inspect the PWA service worker registration and ensure the base path is included in the start url and scope.
Tech stack
typescript
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75