Microsoft/vscode

Option for sticky scroll to prioritize inner blocks

Open

#208,406 opened on Mar 22, 2024

View on GitHub
 (9 comments) (18 reactions) (2 assignees)TypeScript (10,221 forks)batch import
editor-sticky-scrollfeature-requesthelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (Avg merge 11h 43m) (1,000 merged PRs in 30d)

Description

Currently sticky scroll always stick the first lines, which may make it less useful in some situations.

Consider the following case:

<!DOCTYPE html>
<html>
    <body>
        <script>
            class SomeClass {
                constructor() {
                    // Long & complicated code
                    // Long & complicated code
                    // Long & complicated code
                }
            }
        </script>
    </body>
</html>

If we scroll to the comments with a max line count set to 3 for sticky scroll, <html>, <body> and <script> will stick around. However, we might not want to always stare at <html> whenever we write HTML, so it may be better to let <html> make room for inner code blocks.

Current Suggested alternative
"<html>", "<body>" and "<script>" stuck around, as they normally would It might be better if "<script>", "class SomeClass {", and "constructor() {" stuck around instead.

This problem also applies to other languages with a complicated program structure. Adding such an option can sometimes make it more efficient to work with these languages.

Contributor guide

Research direction
Examine the existing sticky scroll implementation to understand how it currently selects lines to stick. Identify the logic for block nesting detection and propose modifications to allow inner blocks to be prioritized over outer ones when the max line count is reached.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65